Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 92
    • Merge requests 92
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !769

[WIP] Feature/improve fuller

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Kilian Weishaupt requested to merge feature/improve-fuller into master Jan 31, 2018
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 7

When executing the test, the "optimized" version (using static variables in the function for values that are expensive to calculate, e.g. involving std::cbrt) is surprisingly slower than the version without static variables (with compiler optimizations).

Without compiler optimization, the opposite is true (which would be expected).

Making the variables static constexpr (and adapting the relevant methods involved), makes the "optimized" version as fast as the other one.

How should we deal with this? Might be related to #441 (closed)

Closes #389 (closed)

Edited Jan 31, 2018 by Kilian Weishaupt
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/improve-fuller