Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 97
    • Issues 97
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 102
    • Merge requests 102
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositories
  • dumuxdumux
  • Merge requests
  • !811

[el2p] Use base class quantities in the NewtonController

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bernd Flemisch requested to merge fix/el2p-newtoncontroller into releases/2.12 Feb 27, 2018
  • Overview 0
  • Commits 1
  • Changes 2

The ElTwoPNewtonController defined several data members that are already present in the base NewtonController. Delete these members and use the corresponding base class members.

The communication call in the function globalResidual of the ElTwoPBaseModel didn't compile. Comment this call such that the function works at least for sequential runs. This allows to use the residual criterion in the Newton solver. Throw if the routine is called in a parallel run.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/el2p-newtoncontroller