Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !861

[tabulatedcomp] fill arrays on the fly

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dennis Gläser requested to merge feature/improve-tabulated-component into master Mar 17, 2018
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

This commit makes !836 (merged) ready for merge.

Instead of filling all arrays during initialization, we fill the data arrays when called. This gets rid of the try and catch blocks in the initializing function and allows for static asserts in the components within functions that are not overloaded. The overhead is one more interpolation call during the first call to the property which should be neglectable. For the pressure(t, rho) functions we have to introduce one additional if statement within each call. For models using only a small fraction of the properties, this commit gets rid of the long initialization times. Execution of test_tabulation with all properties did not show any difference in runtime. The 2p2c tests however run significantly faster because they only need densities and viscosities, making the initialization much faster.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/improve-tabulated-component