Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !924

Fix/box scvf construction

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dennis Gläser requested to merge fix/box-scvf-construction into master Apr 23, 2018
  • Overview 18
  • Commits 3
  • Pipelines 0
  • Changes 3

There has been a bug for the determination of the corners of boundary scvfs in the box scheme. This was probably never really tested but manifested itself in the implementation of the box-dfm scheme now...

Up to now, we were using info only from the intersection geometry, which could have a different ordering on a ug, alu or yasp grid. The work around now was to store a reference to the reference element in the helper class and reuse it when constructing the boundary scvfs. I tested it with Dune 2.5 and Dune 2.6. In the next Dune release, the alias for the reference elements would have to be adapted.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/box-scvf-construction