Merge branch 'fixup/BJS_warnings' into 'master'

[CoupledExercise] Set the Beavers Joeseph condition using setBeaversJoeseph rather than set BJS

Closes #25

See merge request !89

exercises/exercise-coupling-ff-pm/README.md

@@ -131,7 +131,7 @@ values.setDirichlet(Indices::velocityXIdx); // assume no slip on interface
 ```
 with a Beavers-Joseph-Saffman (BJS) boundary condition for the respective momentum balance:
 ``` cpp
-values.setBJS(Indices::momentumXBalanceIdx);
+values.setBeaversJoseph(Indices::momentumXBalanceIdx);
 ```
 
 at the position where the coupling boundary conditions are set in `interface/freeflowsubproblem.hh`.
@@ -187,7 +187,7 @@ in `main.cc` in the subfolder `interface`.
 
 The same is true for the BJS condition, however, here we need to consider the tangential direction:
 ```cpp
-values.setBJS(1 - scvf.directionIndex());
+values.setBeaversJoseph(1 - scvf.directionIndex());
 ```
 
 The final result should look something like this:

exercises/exercise-coupling-ff-pm/models/freeflowsubproblem.hh

@@ -184,7 +184,7 @@ public:
             values.setCouplingNeumann(Indices::conti0EqIdx);
             values.setCouplingNeumann(Indices::conti0EqIdx + 1);
             values.setCouplingNeumann(Indices::momentumYBalanceIdx);
-            values.setBJS(Indices::momentumXBalanceIdx);
+            values.setBeaversJoseph(Indices::momentumXBalanceIdx);
         }
 
         return values;

exercises/exercise-coupling-ff-pm/turbulence/freeflowsubproblem.hh

@@ -209,7 +209,7 @@ public:
             values.setCouplingNeumann(Indices::conti0EqIdx + 1);
             values.setCouplingNeumann(Indices::energyEqIdx);
             values.setCouplingNeumann(Indices::momentumYBalanceIdx);
-            values.setBJS(Indices::momentumXBalanceIdx);
+            values.setBeaversJoseph(Indices::momentumXBalanceIdx);
         }
         return values;
     }

exercises/solution/exercise-coupling-ff-pm/interface/freeflowsubproblem.hh

@@ -196,11 +196,11 @@ public:
             values.setDirichlet(Indices::velocityXIdx); // assume no slip on interface
 #elif EXNUMBER == 2
             // set the Beaver-Joseph-Saffman slip condition for the tangential momentum balance equation
-            values.setBJS(Indices::momentumXBalanceIdx);
+            values.setBeaversJoseph(Indices::momentumXBalanceIdx);
 #else
             // set the Beaver-Joseph-Saffman slip condition for the tangential momentum balance equation,
             // consider orientation of face automatically
-            values.setBJS(1 - scvf.directionIndex());
+            values.setBeaversJoseph(1 - scvf.directionIndex());
 #endif
         }
 

exercises/solution/exercise-coupling-ff-pm/models/freeflowsubproblem.hh

@@ -187,7 +187,7 @@ public:
             values.setCouplingNeumann(Indices::conti0EqIdx);
             values.setCouplingNeumann(Indices::conti0EqIdx + 1);
             values.setCouplingNeumann(Indices::momentumYBalanceIdx);
-            values.setBJS(Indices::momentumXBalanceIdx);
+            values.setBeaversJoseph(Indices::momentumXBalanceIdx);
         }
 
         return values;

exercises/solution/exercise-coupling-ff-pm/turbulence/freeflowsubproblem.hh

@@ -220,7 +220,7 @@ public:
             values.setCouplingNeumann(Indices::conti0EqIdx + 1);
             values.setCouplingNeumann(Indices::energyEqIdx);
             values.setCouplingNeumann(Indices::momentumYBalanceIdx);
-            values.setBJS(Indices::momentumXBalanceIdx);
+            values.setBeaversJoseph(Indices::momentumXBalanceIdx);
         }
         return values;
     }