Skip to content
Snippets Groups Projects
Commit 43ba30b9 authored by Timo Koch's avatar Timo Koch
Browse files

Merge branch 'cleanup/computemolarvolumes-peng-robinson' into 'master'

[cleanup] Remove unused PengRobinsonMixture::computeMolarVolumes

See merge request !2813
parents 33cba3f1 29b1b4f5
No related branches found
No related tags found
1 merge request!2813[cleanup] Remove unused PengRobinsonMixture::computeMolarVolumes
Pipeline #8179 passed
+3
...@@ -42,6 +42,7 @@ for (const auto& element : elements(gridGeometry.gridView())) ...@@ -42,6 +42,7 @@ for (const auto& element : elements(gridGeometry.gridView()))
### Immediate interface changes not allowing/requiring a deprecation period: ### Immediate interface changes not allowing/requiring a deprecation period:
- __Virtual interface of GridDataTransfer__: The `GridDataTransfer` abstract base class now required the Grid type as a template argument. Furthermore, the `store` and `reconstruct` interface functions do now expect the grid as a function argument. This allows to correctly update grid geometries and corresponding mapper (see "Construction and update of GridGeometries changed" above in the changelog) - __Virtual interface of GridDataTransfer__: The `GridDataTransfer` abstract base class now required the Grid type as a template argument. Furthermore, the `store` and `reconstruct` interface functions do now expect the grid as a function argument. This allows to correctly update grid geometries and corresponding mapper (see "Construction and update of GridGeometries changed" above in the changelog)
- `PengRobinsonMixture::computeMolarVolumes` has been removed without deprecation. It was used nowhere and did not translate.
### Deprecated properties/classes/functions/files, to be removed after 3.5: ### Deprecated properties/classes/functions/files, to be removed after 3.5:
......
...@@ -50,23 +50,6 @@ class PengRobinsonMixture ...@@ -50,23 +50,6 @@ class PengRobinsonMixture
static const Scalar w; static const Scalar w;
public: public:
/*!
* \brief Computes molar volumes \f$\mathrm{[m^3 / mol]}\f$ where the Peng-Robinson EOS is
* true.
* \param Vm Molar Volume \f$\mathrm{[m^3 / mol]}\f$
* \param fs Thermodynamic state of the fluids
* \param params Parameters
* \param phaseIdx The phase index
* \return Number of solutions.
*/
template <class MutableParams, class FluidState>
static int computeMolarVolumes(Scalar *Vm,
const MutableParams &params,
int phaseIdx,
const FluidState &fs)
{
return PengRobinson::computeMolarVolumes(Vm, params, phaseIdx, fs);
}
/*! /*!
* \brief Returns the fugacity coefficient \f$\mathrm{[-]}\f$ of an individual * \brief Returns the fugacity coefficient \f$\mathrm{[-]}\f$ of an individual
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment