Also remove unnecessary inclusions of the header.

Remove unnecessesary part from updateAnalyticalSolution.

Also some of the smaller suggestions of the review process are
integrated.

- use std::array instead of std::vector.
- In general manningN is a spatial parameter, so put it there, even
  if it is a constant in the rough channel test.
- Rename the water depth from h to waterDepth.
- Fix the dambreak test, which was incidentially broken by the work on thei
  rouch channel test.

The test provides a simple channel flow based on the friction law after
Manning. Normal flow is assumed, therefore the formular after Gaukler,
Manning and Strickler can be used to get an analytic solution.

Martin Utz authored 5 years ago and Timo Koch committed 5 years ago

Add the entries for the shallow water model in module.txt.
Ensure that all classes and functions have docstrings.
Document the ShallowWaterFlux class.

Sina Ackermann authored 6 years ago and Simon Emmert committed 6 years ago

* Now: // Add model specific output fields

Kilian Weishaupt authored 6 years ago and Timo Koch committed 6 years ago

* export PrivarSwitch in VolVars
* do not set PriVarSwitch property in model.hh anymore

Simon Emmert authored 6 years ago and Timo Koch committed 6 years ago

This involes small changes for the 2p non-isothermal problem and the
mpnc-comparison references and links.

Bernd Flemisch authored 6 years ago and Kilian Weishaupt committed 6 years ago

Rename `VtkOutputFields` to `IOFields`. Add `primaryVariableName`
functions, don't use centralized names yet. Add required template
parameters. Adapt properties correspondingly.

This patch reduces dependencies and makes usage of linear solvers more flexible, i.e. for two problems with different typetag

* Linear solvers don't need type tag anymore, in fact they don't need any template params
* the preconditioner block size is now provided for the solve method (see e.g. staggered newton controller)
* the amg has a convencience alias using a TypeTag but is "independent" through indirection via the traits