Timo Koch authored 5 years ago and Ned Coltman committed 5 years ago

FluidSystem::getMainComponent returns the main componet index of the phase.
This doesn't actually make sense for the tracer models which why this commit also
* removes getMainComponent for tracer fluid systems (Changelog amended)
* guards all occurences of getMainComponent in code that works for tracer too
with constexpr if

Timo Koch authored 5 years ago and Ned Coltman committed 5 years ago

The idea of the tracer model is really tied to Fickian diffusion and components
with small concentration diffusing in a bulk phase. Hence also it's name.
The Maxwell-Stefan test actual models 3 gaseous components where none of
the components is really the main phase but most importantly there is no
bulk phase with a main component that is not considered in the equations.
Thus the 1pnc model is the right choice for such a test.
This changes the test to derive from the 1pnc model. As for the given
setting with only Neumann boundaries the 1pnc wouldn't convergence for
a compressible fluid, the Ideal gas law is used to model a
compressible gas.

The same test actually exists for the 1pnc model already in 1pnc/implicit/1p3c.
Thus this commit simply removes the tracer test.

Dennis Gläser authored 5 years ago and Ned Coltman committed 5 years ago

With the reduced number of arguments to be passed to the lambdas that
return the considered tensor (permeability / diffusion coefficient /
thermal conductivity), we don't need this interface anymore that was
mainly designed to obtain all the arguments that were required for the
tensor lambda interface.

Dennis Gläser authored 5 years ago and Ned Coltman committed 5 years ago

Since we store the effective coefficients in the volume variables we
don't need the cumbersome extraction of permeabilities, diffusion
coefficients etc. anymore.

*  Add docu
*  Adjust getIndex formula, constexpr
*  Add switching to operators

Dennis Gläser authored 5 years ago and Ned Coltman committed 5 years ago

The check if a volume-variables implementation has the new interface or
not does not really help, because these user-defined vol vars will not
work/compile with the changes introduced in the previous commits, anyway.

Dennis Gläser authored 5 years ago and Ned Coltman committed 5 years ago

[box] throw deprecation warning if vol vars do not implement an effectiveDiffusionCoefficient() function

Dennis Gläser authored 5 years ago and Ned Coltman committed 5 years ago

[mpfa] throw deprecation warning if vol vars do not implement an effectiveDiffusionCoefficient() function

Dennis Gläser authored 5 years ago and Ned Coltman committed 5 years ago

[fickslaw] throw deprecation warning if vol vars implementation does not have an effectiveDiffusionCoefficient() interface