Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 88
    • Merge requests 88
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !1647

Feature/generalize fvgridgeometry

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Simon Emmert requested to merge feature/generalize-fvgridgeometry into master Jun 26, 2019
  • Overview 56
  • Commits 15
  • Pipelines 0
  • Changes 438

What this MR does / why does DuMux need it:

So far this renames FVGridGeometry to GridGeometry for box, tpfa, mpfa and staggered.

** Things left to do:**

  • deprecate FVGridGeometry property correctly
  • open new MR with renaming and deprecation of all places where a public FVGridGeometry is used --> see !1700 (merged)
  • discuss if a warning needs to be thrown and where (e.g. similar to the property-system warning
  • merge !1700 (merged) after testing this branch thoroughly (this branch is how it will look like to a user, before taking care of the deprecation warnings)

Special notes for your reviewer:

This now only changes and deprecates the aliases for the fvelementgeometry.hh files, the renaming and deprecation of all other instances (in the tests etc) will be done in a new MR.

Fixes #719 (closed)

Edited Oct 09, 2019 by Bernd Flemisch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/generalize-fvgridgeometry