Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 87
    • Merge requests 87
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !2808

PengRobinson::computeMolarVolume changes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Dmitry Pavlov requested to merge dpavlov/dumux:feature/molarvolumeusecrit into master Aug 30, 2021
  • Overview 28
  • Commits 7
  • Pipelines 7
  • Changes 1
  • Ignoring the first two roots of the equation for Z in the smallest one is zero or negative. There was a comment documenting that behavior, but it was not implemented.

  • Throwing NumericalProblem if no positive Z has been found or the number of roots is 2 or more than 3 (no check was in place)

  • Throwing NumericalProblem if the found molar volume turned out to be zero, negative, or NaN. (Replacing assert)

  • Added handleOneRootSpecially flag (true by default). If false, the single-root case works as the three-roots case, without special treatment which causes the Michelsen test for a mix of hydrocarbons to fail to deliver.

Edited Sep 04, 2021 by Dmitry Pavlov
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/molarvolumeusecrit