Skip to content

[test] Test periodic subgrids

Ned Coltman requested to merge feature/test_periodic_subgrid into master

What this MR does / why does DuMux need it:

This extends the test suite to further cover subgrids of periodic SP host grids.

  • The test of the subgrid gridmanager is extended to test periodicity detection of the wrapped grid.
  • Adds a freeflow test in test/freeflow/navierstokes/periodic/porescale with geometry generated using createGridFromImage() from a .pbm file and tiles this periodic geometry into a larger domain.

Notes for the reviewer

With !3888 (merged) DuMux now supports periodic SubGrids as long as the host grid's periodicity is supported.

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
Edited by Timo Koch

Merge request reports

Loading