Skip to content
GitLab

Draft: test periodic(SP) subgrids

Open Ned Coltman requested to merge feature/test_periodic_subgrid into master

What this MR does / why does DuMux need it:

This extends the subgrid manager to accept subgrid of SP host grids, and to cut them using the .pbm create grid from image methods.

Notes for the reviewer

At the moment, periodicity is not forwarded by the subgrid interface, but a branch exists where this is done (feature/SPGrid-Periodicity). Without this branch, the additions made to the test will fail due to lack of periodicity.

In addition, the createGridFromImage() has been added to the base class here, as it has previously only been accepted for YASP grid variations. This may need to be changed?

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.

Merge request reports