Skip to content

Add SimpleCO2 component

Mathis Kelm requested to merge feature/simpleCO2 into master

What this MR does / why does DuMux need it:

Adds a SimpleCO2 component and adjusts BrineCO2 fluidsystem and binarycoefficients to receive a component instead of just a CO2Table. Used in example/biomineralization instead of CO2 table.

Fixes #1162 (closed)

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
  • (if not applicable remove) are newly introduced or modified physical values/functions backed up with a scientific reference (including doi) in the docs?
  • (if not applicable remove) if the examples are modified, is the documentation regenerated (using generate_example_docs.py)
Edited by Mathis Kelm

Merge request reports

Loading