Skip to content

[material][SimpleCO2] fix enthalpy calculation

Mathis Kelm requested to merge fix/simpleCO2 into master

What this MR does / why does DuMux need it:

Fixes some errors related to the SimpleCO2 component.

We should add a test that uses the nonisothermal aspects of this component. The BrineCO2 fluidsystem is not well suited for it, as it uses liquidX functions in strange places. As that fluidsystem was created for supercritical conditions it's not really a good fit for the SimpleCO2 component anyway.

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
  • (if not applicable remove) are newly introduced or modified physical values/functions backed up with a scientific reference (including doi) in the docs?
  • (if not applicable remove) if the examples are modified, is the documentation regenerated (using generate_example_docs.py)
Edited by Timo Koch

Merge request reports