Skip to content

Feature/fvgeometry remove geometry/corners mpfa/staggered

Mathis Kelm requested to merge feature/fvgeometry-geometry-scv into master

What this MR does / why does DuMux need it:

Addresses #1173 , removing corner storage where directly possible.

Notes for the reviewer

  • For mpfa faces the corner storage is still used for vertexCorner() and faceCorner() as well as corners() which have been deprecated. The local view of the grid geometry offers corresponding funtionality.
  • For (old) staggered/freeflow faces the corner storage is still used for faceLength. Storing reduced information locally.

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
Edited by Timo Koch

Merge request reports