Skip to content

Draft: Remove scv/scvf corners

Mathis Kelm requested to merge feature/remove-scv-scvf-corners into master

What this MR does / why does DuMux need it:

Related to #1173. The box specializations for multidomain/facet and porousmediumflow/boxfdm still had corners stored on the scv(f)s. The boxfdm/subcontrolvolume.hh exposed corners_[0] as dofPosition() and still stores this corner as dofPosition_. While the corners can be obtained from the geometryHelper, for scv containing a fracture the corners are constructed using two indices not (obviously) stored in the scv. Are these indices readily available? Is storing the indices and constructing all corners better than storing dofPosition?

Removes deprecations after release 3.8: Fixes #1327.

Notes for the reviewer

TODO: insert text here

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.

Merge request reports