Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • dumux dumux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 92
    • Merge requests 92
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • dumux-repositoriesdumux-repositories
  • dumuxdumux
  • Merge requests
  • !3202

Feature/Prepare for box without corner storage

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Timo Koch requested to merge feature/box-without-corner-storage into master Jul 14, 2022
  • Overview 4
  • Commits 12
  • Pipelines 11
  • Changes 10

What this MR does / why does DuMux need it:

  • Adds two new interface to the box fv element geometry geometry(scv) and geometry(scvf) that produce a geometry on-the-fly. This obviates the need for storing corners in the sub entities themselves.
  • Deprecates box scv/scvf.geometry() and scv/scvf.corner(i)
  • Adds a deprecation helper to get rid of deprecation warnings (but deprecation warning are not all fixed in this MR)
  • Extends the interface of extrusion, necessary to have a more relaxed geometry interface

Follow-up from !3199 (merged).

Addresses #1173 for box

  • use new center from !3230 (merged)

Notes to reviewer: The changes lead to quite a lot of deprecation warnings which need to be fixed before the release. But I propose to do this in another cleanup MR. These changes will allow for a box scv/scvf implementation after the release which significantly reduces memory overhead when caching is enabled.

Edited Sep 04, 2022 by Timo Koch
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/box-without-corner-storage