Skip to content

Draft: feature/new-tpfa-grid-geometry

Dennis Gläser requested to merge feature/new-experimental-assembly-cctpfa-grid-geom into feature/new-experimental-assembly

What this MR does / why does DuMux need it:

TODO: insert text here

TODOS:

  • we should probably add support for injecting custom stencils (currently we have that extended source stencil somewhere...) - EDIT: should be fine because it seems that we currently do this in the classes related to coupling, which is probably better
  • extraction/reusage of the BasicGeometry, which is currently possible on master - EDIT: should be fine, because this inherits from BaseGridGeometry, which takes care of this
  • we may think of making grid geometries "observable" to design our depending classes such that they can automatically update in adaptive simulations (probably best to postpone once it actually becomes relevant during development) - EDIT: this would be a change to BaseGridGeometry, so I would postpone that (I opened an issue for that: #1192 (closed))
  • Add a unique local index per scvf (needed for stationary flux fields e.g. in tracer model?)
  • Add a test on a corner point grid
  • remove performance test

Relates #1173

Notes for the reviewer

TODO: insert text here

Before you request a review from someone, make sure to revise the following points:

  • does the new code follow the style guide?
  • do the test pipelines pass? (see guide on how to run pipelines for a merge request)
  • is the code you changed and/or the new code you wrote covered in the test suite? (if not, extend the existing tests or write new ones)
  • does your change affect public interfaces or behavior, or, does it introduce a new feature? If so, document the change in CHANGELOG.md.
  • is the list of the header includes complete? ("include what you use")
  • all files have to end with a \n character. Make sure there is no \ No newline at end of file comment in "Changes" of this MR.
  • (if not applicable remove) are newly introduced or modified physical values/functions backed up with a scientific reference (including doi) in the docs?
  • (if not applicable remove) if the examples are modified, is the documentation regenerated (using generate_example_docs.py)
Edited by Dennis Gläser

Merge request reports