[test] Fix signature in test_msfreeflow's fluid system's binaryDiffusionCoefficient

See merge request !1159

[test][multidomain] Remove unused reference solutions.

See merge request !1158

[test][navierstokesnc] Fix test test_msfreeflow. Make binaryDiffusionCoefficient have the same argument as in fluidsystem base class.

[cleanup][amg] Remove unused variable

See merge request !1154

Fix parallel calculations for grids with ghost cells

Closes #535

See merge request !1131

Bernd Flemisch authored 6 years ago and Timo Koch committed 6 years ago

Also fix the test itself in the following sense. By default, in the
box method, material law parameters are evaluated at scv centers,
while primary variables are evaluated at vertices. If no interface
condition is used, the secondary variables handed to the Vtk
writer might now differ depending on the order in which the scvs
are evaluated for each vertex. In order to saty consistent, this
test evaluates the material law parameters at the vertex position.

Bernd Flemisch authored 6 years ago and Timo Koch committed 6 years ago

This hasn't happened until now in dune-grid such that AMG uses
sequential traits for a parallel UGGrid. Implement this as a
temporary solution until it is fixed upstream.

Bernd Flemisch authored 6 years ago and Timo Koch committed 6 years ago

This recovers results from 2.12. However, these results also are wrong.

[test][vtucompare] Convert to list for comparison

See merge request !1152

Feature/test electrochemistryni

See merge request !1151

Resolve "Non-implemented functions lead to infinite loops in fluid system"

Closes #534

See merge request !1133

[staggered][fvElementGeometry] Inherit from cctpfa fvElementGeometry

See merge request !1146

[fluidsystems] remove isLiquid in favor of isGas

See merge request !1142

[staggered] add the scalar normal velocity to the Vtk output

See merge request !1149

This will facilitate reading from Vtk files.

Fix/point in geometry 2d simplex

Closes #479

See merge request !1141

Resolve "Rename FluidSystem::BaseFluidSystem to FluidSystem::Base"

Closes #533

See merge request !1134

Cleanup/diffusion laws

Closes #364

See merge request !1132

Katharina Heck authored 6 years ago and Kilian Weishaupt committed 6 years ago

[cleanup][freeflow] calculate molar flux to mass flux in case of useMoles false in fluxvariables instead of in ficks law. diffusion laws should always return the molar flux

* using cctpfa fvElementGeometry comes with a lot of difficulties,
  furthermore scvf(eIdx, localScvfIdx) is still needed

Cleanup/remove enthalpy and viscosity from constraintsolvers

Closes #519

See merge request !1136

[newtonsolver] Pass shared_ptr by copy

See merge request !1144

* won't compile otherwise

Also replace all calls to isLiquid by equivalent calls to isGas